Windows: Fix address_imp_test #11334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will squash the commits when the PR is ready to get merged if this alright with everyone |
|
Is this tested? From what I have read, abstract names don't work with AF_UNIX on Windows yet. Sunil confirmed that the documentation is incorrect in microsoft/WSL#4240 |
|
@nigriMSFT I run the envoy tests to validate it. I will look into the issue as well |
|
As we understood the public facing blogs and notes, abstract names aren't supported on Windows, nor apparently on apple (bsd-derived socket stack). If this is true, we should be able to normalize throughout against |
|
I also confirmed it internally that abstract names aren't supported on Windows for security reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Enable Abstract sockets for Windows and fix test permissions
Additional Description:
With this change we aim to add full support for the address_imp_test on Windows. To achieve this we made the following changes:
BasicPermissionwe set the mode to be666. This allows us to verify in linux that we set the permissions of the socket correctly. This is the equivalent to_S_IREAD | _S_IWRITEin Windows. In case that we need more granular permission model, we would need to use ACL in Windows.Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A